Skip to content

Sam's attempt at a welcoming CONTRIBUTING file. - #278

Merged
samcunliffe merged 3 commits into
mainfrom
sc/245-contributing.md
Jan 23, 2024
Merged

Sam's attempt at a welcoming CONTRIBUTING file.#278
samcunliffe merged 3 commits into
mainfrom
sc/245-contributing.md

Conversation

@samcunliffe

Copy link
Copy Markdown
Member

Note

Reviewers:
Please do double-check that what I've written doesn't break the flow of README.md and that I've kept the tone encouraging.

@samcunliffe samcunliffe added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 23, 2024
Comment thread README.md
@paddyroddy

paddyroddy commented Jan 23, 2024

Copy link
Copy Markdown
Member

💔

@paddyroddy paddyroddy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful, but can you wrap to ~80 chars for the README?

Comment thread CONTRIBUTING.md Outdated
Comment on lines +33 to +37
[website]: https://github-pages.arc.ucl.ac.uk/python-tooling
[UCL ARC]: https://ucl.ac.uk/arc
[open an issue]: https://github.com/UCL-ARC/python-tooling/issues/new/choose
[Discussions tab]: https://github.com/UCL-ARC/python-tooling/discussions
[RSE]: https://society-rse.org/about/history

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious as to why this syntax? Always makes me think of RST

@samcunliffe samcunliffe Jan 23, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, but literally only because it doesn't interrupt the flow of the text if you read the raw markdown.

So I can write...

We are actively encouraging users to ask questions and start discussions in the
[discussions tab] of this repository. Does something seem like it's broken?
Please go ahead and [open an issue]!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example: I would often read raw markdown by cat ing things in the terminal.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like that bit, less a fan of [][]

@matt-graham matt-graham left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads well to me - good balance of getting across key details and being welcoming. Made a few minor suggestions but not strongly wedded to any of them and would be happy for this to go in as is from my perspective.

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread README.md
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
@samcunliffe

samcunliffe commented Jan 23, 2024

Copy link
Copy Markdown
Member Author

Looks beautiful, but can you wrap to ~80 chars for the README?

  • wrap to ~80 chars for the README?

@samcunliffe
samcunliffe force-pushed the sc/245-contributing.md branch from 8b8b6ad to d6e33f6 Compare January 23, 2024 17:02

@paddyroddy paddyroddy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍🍳💋

@samcunliffe
samcunliffe merged commit 14bd74b into main Jan 23, 2024
@samcunliffe
samcunliffe deleted the sc/245-contributing.md branch January 23, 2024 17:24
dstansby pushed a commit that referenced this pull request Jan 23, 2024
... too much development velocity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants