Skip to content

build: update dependency @web/test-runner-puppeteer to v1#3839

Open
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/web-test-runner-puppeteer-1-x
Open

build: update dependency @web/test-runner-puppeteer to v1#3839
angular-robot wants to merge 1 commit into
angular:mainfrom
angular-robot:ng-renovate/web-test-runner-puppeteer-1-x

Conversation

@angular-robot

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@web/test-runner-puppeteer (source) ^0.18.0^1.0.0 age adoption passing confidence

  • If you want to rebase/retry this PR, check this box

Release Notes

modernweb-dev/web (@​web/test-runner-puppeteer)

v1.0.0

Compare Source

Major Changes
  • 5260164: Drop support for Node.js 18 and 20, which have reached end-of-life. The minimum supported Node.js version is now 22.0.0.
    The Node code is compiled to ES2024 which is aligned with the Node 22.
Patch Changes

See associated pull request for more information.
@angular-robot angular-robot added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only] labels Jul 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @web/test-runner-puppeteer dependency to version ^1.0.0 along with its lockfile. The review feedback recommends upgrading all core @web/test-runner packages to ^1.0.0 simultaneously to prevent version mismatches, potential runtime conflicts, and lockfile bloat.

Comment on lines 24 to +26
"@web/test-runner": "^0.20.2",
"@web/test-runner-core": "^0.13.4",
"@web/test-runner-puppeteer": "^0.18.0",
"@web/test-runner-puppeteer": "^1.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating only @web/test-runner-puppeteer to ^1.0.0 while keeping @web/test-runner and @web/test-runner-core on older versions (^0.20.2 and ^0.13.4 respectively) leads to duplicate and mismatched versions of @web/test-runner-core and @web/test-runner-chrome in the dependency tree (as seen in the pnpm-lock.yaml changes). To prevent potential runtime issues, plugin registration conflicts, and bloated lockfiles, all core @web/test-runner packages should be upgraded to ^1.0.0 together.

Suggested change
"@web/test-runner": "^0.20.2",
"@web/test-runner-core": "^0.13.4",
"@web/test-runner-puppeteer": "^0.18.0",
"@web/test-runner-puppeteer": "^1.0.0",
"@web/test-runner": "^1.0.0",
"@web/test-runner-core": "^1.0.0",
"@web/test-runner-puppeteer": "^1.0.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: automation This PR is targeted to only merge into the branch defined in Github [bot use only]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant