Skip to content

build: update dependency @web/test-runner-puppeteer to v1 #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
angular-robot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: update dependency @web/test-runner-puppeteer to v1 #3839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/rules/rules_browsers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"@web/dev-server-rollup": "^0.6.4",
"@web/test-runner": "^0.20.2",
"@web/test-runner-core": "^0.13.4",
"@web/test-runner-puppeteer": "^0.18.0",
"@web/test-runner-puppeteer": "^1.0.0",
Comment on lines 24 to +26

@gemini-code-assist gemini-code-assist Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Updating only @web/test-runner-puppeteer to ^1.0.0 while keeping @web/test-runner and @web/test-runner-core on older versions (^0.20.2 and ^0.13.4 respectively) leads to duplicate and mismatched versions of @web/test-runner-core and @web/test-runner-chrome in the dependency tree (as seen in the pnpm-lock.yaml changes). To prevent potential runtime issues, plugin registration conflicts, and bloated lockfiles, all core @web/test-runner packages should be upgraded to ^1.0.0 together.

Suggested change
"@web/test-runner": "^0.20.2",
"@web/test-runner-core": "^0.13.4",
"@web/test-runner-puppeteer": "^0.18.0",
"@web/test-runner-puppeteer": "^1.0.0",
"@web/test-runner": "^1.0.0",
"@web/test-runner-core": "^1.0.0",
"@web/test-runner-puppeteer": "^1.0.0",

"get-port": "^7.1.0",
"jasmine": "^6.0.0",
"protractor": "^7.0.0",
Expand Down
133 changes: 125 additions & 8 deletions bazel/rules/rules_browsers/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.