ARROW-6624: [C++][Python] Add SparseTensor.ToTensor() method#5539
Closed
rok wants to merge 3 commits into
Closed
Conversation
rok
force-pushed
the
ARROW-6624
branch
2 times, most recently
from
8f8594d to
a7a9248
Compare
rok
changed the title
rok
force-pushed
the
ARROW-6624
branch
14 times, most recently
from
7c9a5d5 to
899ac02
Compare
rok
changed the title
Member
Author
|
@mrkn we discussed this earlier (#4446 (comment)). Can you please review if this proposal makes sense? |
rok
force-pushed
the
ARROW-6624
branch
3 times, most recently
from
e66814d to
8c01cac
Compare
Codecov Report
@@ Coverage Diff @@
## master #5539 +/- ##
===========================================
+ Coverage 70.3% 89.5% +19.19%
===========================================
Files 785 797 +12
Lines 95472 119114 +23642
Branches 1501 0 -1501
===========================================
+ Hits 67123 106614 +39491
+ Misses 27984 12500 -15484
+ Partials 365 0 -365
Continue to review full report at Codecov.
|
rok
changed the title
Member
|
@mrkn Would you have time to review this? You are more acquainted with the sparse formats than I am. |
Member
mrkn
requested changes
Oct 17, 2019
mrkn
left a comment
mrkn
left a comment
Member
There was a problem hiding this comment.
Thank you for doing this. I left some comments. Please check them.
rok
force-pushed
the
ARROW-6624
branch
5 times, most recently
from
bad2aeb to
f35b7af
Compare
Member
Author
mrkn
requested changes
Oct 18, 2019
mrkn
left a comment
mrkn
left a comment
Member
There was a problem hiding this comment.
I added some comments. Please check them.
rok
force-pushed
the
ARROW-6624
branch
2 times, most recently
from
bac80d5 to
9b02d5a
Compare
Member
Author
|
@mrkn thanks for the feedback :). I've made changes, please review. |
rok
force-pushed
the
ARROW-6624
branch
5 times, most recently
from
1556be6 to
984e769
Compare
mrkn
approved these changes
Oct 20, 2019
Member
|
+1 approved. |
Member
|
@rok Thank you very much! |
Member
Author
|
Thanks for your help @mrkn! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to solve ARROW-6624.