Skip to content

ARROW-6671: [C++][Python] Use more consistent names for sparse tensor items#5605

Closed
mrkn wants to merge 1 commit into
apache:masterfrom
mrkn:ARROW-6671
Closed

ARROW-6671: [C++][Python] Use more consistent names for sparse tensor items#5605
mrkn wants to merge 1 commit into
apache:masterfrom
mrkn:ARROW-6671

Conversation

@mrkn

@mrkn mrkn commented Oct 8, 2019

Copy link
Copy Markdown
Member

No description provided.

@mrkn

mrkn commented Oct 8, 2019

Copy link
Copy Markdown
Member Author

This pull-request renames the following names:

  • SparseTensorCOO → SparseCOOTensor
  • SparseTensorCSR → SparseCSRMatrix
  • sparse_tensor_coo → sparse_coo_tensor
  • sparse_tensor_csr → sparse_csr_matrix

And, this removes SparseMatrixCSR symbol.

@github-actions

github-actions Bot commented Oct 8, 2019

Copy link
Copy Markdown

@mrkn

mrkn commented Oct 8, 2019

Copy link
Copy Markdown
Member Author

This pull-request will break #4990.

@pitrou

pitrou commented Oct 8, 2019

Copy link
Copy Markdown
Member

@wesm

@pitrou

pitrou commented Oct 16, 2019

Copy link
Copy Markdown
Member

Rebased.

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Will merge once green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants