Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore sink-batch forward progress
#18582 changed the memory reservation owned by
PipeTabletEventBatchfrom a normalPipeMemoryBlockto aPipeTabletMemoryBlock. This made sink-batch growth subject to the tablet data-structure admission thresholds. Once retained tablet memory crossed that sub-quota, a sink batch could no longer grow enough to transfer and acknowledge events, so the retained/floating memory could not be released either.This PR restores the batch reservation to a normal pipe memory block. Tablet and TsFile allocations remain bounded by their data-structure thresholds, while sink batches can use the remaining non-floating memory to make downstream progress and release retained events.
Back off memory-timeout retries
PipeAbstractSinkSubtaskpreviously retriedMEMORY_TIMEOUTfailures immediately while applying backoff to the other transient resource failures. The immediate retry loop could consume several CPU cores and flood logs while memory remained unavailable. Memory timeouts now use the existing non-report exception backoff after logging the transient condition.Regression coverage
PipeSleepIntervalTest: 4 tests passed.PipeMemoryManagerResizeTestandPipeTransferBatchReqBuilderTest: 8 tests passed after isolated compilation against the module classpath.git diff --checkpassed for the changed files.A full DataNode reactor compile was also attempted, but this Windows host exhausted native JVM memory while compiling the 2,983 DataNode sources. The focused DataNode classes and tests compile and pass independently.
This PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
PipeTabletEventBatchPipeAbstractSinkSubtaskPipeTransferBatchReqBuilderTestPipeSleepIntervalTest