Skip to content

[flink] Fix flaky test duplicate nullable PK IT - #9117

Merged
JingsongLi merged 1 commit into
apache:masterfrom
ArnavBalyan:arnavb/flink-flaky-ut
Aug 10, 2026
Merged

[flink] Fix flaky test duplicate nullable PK IT#9117
JingsongLi merged 1 commit into
apache:masterfrom
ArnavBalyan:arnavb/flink-flaky-ut

Conversation

@ArnavBalyan

Copy link
Copy Markdown
Member

Purpose

  • The test inserts two null pks in one insert and asserts the second one wins.
  • Sequence numbers are assigned on arrival and deduplication keeps the highest, so the surviving row varies depending on the arrival order. (18 of 39 runs failed)
  • Fix the assertion to be compatible with the deduplication. All runs pass post fix.

Tests

  • UT fix

@ArnavBalyan ArnavBalyan changed the title [flink] Fix flaky test duplicate nullable key [flink] Fix flaky test duplicate nullable PK IT Aug 8, 2026
@ArnavBalyan ArnavBalyan reopened this Aug 10, 2026
@ArnavBalyan
ArnavBalyan force-pushed the arnavb/flink-flaky-ut branch from a362a31 to b068ed3 Compare August 10, 2026 07:12
@ArnavBalyan

ArnavBalyan commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

#9118 recently merged fixes similar assertion but was not checking that full row survives deduplication. This PR checks stronger full row coverage.

@ArnavBalyan

Copy link
Copy Markdown
Member Author

CI failure is transient

@JingsongLi

Copy link
Copy Markdown
Contributor

+1

@JingsongLi
JingsongLi merged commit db1b5c7 into apache:master Aug 10, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants