[flink] Fix nullable primary key test across Flink versions - #9118
Merged
Conversation
Without a sequence field, Flink 1.x and 2.x may deliver duplicate VALUES rows in different orders, so the test cannot require one payload to win. Assert only the primary keys to keep the test focused on nullable-key deduplication. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
Member
|
We already have a PR #9117 for this |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
testDuplicateNullablePrimaryKeyWithinSingleCommitassumed that the second input row always wins without a sequence field. However, Flink 1.x and 2.x may deliver the rows in different orders, making the assertion version-dependent.Assert only the primary keys so the test continues to verify nullable-key deduplication without relying on an undefined winner.
Tests
NullablePrimaryKeyITCase#testDuplicateNullablePrimaryKeyWithinSingleCommitwith Flink 1NullablePrimaryKeyITCase#testDuplicateNullablePrimaryKeyWithinSingleCommitwith Flink 2