chore(dependencies): Remove jschardet from the frontend dependency graph#4475
Merged
Conversation
Contributor
Author
|
@bobbai00, please double-check if jschardet is removed in the final binary. |
bobbai00
added a commit
to bobbai00/texera
that referenced
this pull request
Apr 23, 2026
…nt deps Removes entries that are no longer bundled after the following upstream PRs: - apache#4463 drop `twittered` (and its Sonar/jtidy/Maven-tooling transitive chain) - apache#4474 drop `python-lsp-server` (and its pylint/rope/astroid chain + extras) - apache#4475 drop `jschardet` from the frontend - apache#4473 pin torch to CPU wheel on Linux x86_64 (removes nvidia-*-cu12) - apache#4386 drop `mysql-connector-java` Adds entries for newly-bundled deps surfaced by the reconciliation: - `org.eclipse.collections` + `-api` under EDL-1.0 - Python `imageio` under BSD-2-Clause - Python `lazy-loader`, `scikit-image`, `tifffile` under BSD-3-Clause Also drops the now-redundant NOTICE-binary W3C block for xml-apis, the entire NVIDIA CUDA section in LICENSE-binary, and the Java HTML Tidy License section. Verified: the checker reports zero STALE/ADDED across JVM, Python, and npm ecosystems against a fresh `sbt dist` / frontend build / pip install. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bobbai00
added a commit
to bobbai00/texera
that referenced
this pull request
Apr 23, 2026
PR apache#4475 was intended to remove jschardet via a `packageExtensions` rule, but the rule targets `@codingame/monaco-vscode-api@*` while package.json aliases that package as `vscode`. Yarn resolves the aliased ident in yarn.lock and never fires the rule — see the reopened apache#4461 for details. Dropping the LICENSE-binary entry here since jschardet is no longer declared in the desired bundle. The actual removal from the shipped artifact is tracked in apache#4461 and will be fixed separately. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bobbai00
added a commit
that referenced
this pull request
Apr 23, 2026
#4480) ### What changes were proposed in this PR? Attempt to fix the PR #4475 ### Any related issues, documentation, discussions? Closes #4461 ### How was this PR tested? ``` rm -rf frontend/node_modules yarn --cwd frontend install find frontend/node_modules -maxdepth 2 -name 'jschardet*' -type d grep -c 'jschardet' frontend/yarn.lock grep -B1 -A1 'jschardet' frontend/yarn.lock | head ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.7) --------- Co-authored-by: Jiadong Bai <43344272+bobbai00@users.noreply.github.com>
bobbai00
added a commit
to bobbai00/texera
that referenced
this pull request
Apr 23, 2026
…nt deps Removes entries that are no longer bundled after the following upstream PRs: - apache#4463 drop `twittered` (and its Sonar/jtidy/Maven-tooling transitive chain) - apache#4474 drop `python-lsp-server` (and its pylint/rope/astroid chain + extras) - apache#4475 drop `jschardet` from the frontend - apache#4473 pin torch to CPU wheel on Linux x86_64 (removes nvidia-*-cu12) - apache#4386 drop `mysql-connector-java` Adds entries for newly-bundled deps surfaced by the reconciliation: - `org.eclipse.collections` + `-api` under EDL-1.0 - Python `imageio` under BSD-2-Clause - Python `lazy-loader`, `scikit-image`, `tifffile` under BSD-3-Clause Also drops the now-redundant NOTICE-binary W3C block for xml-apis, the entire NVIDIA CUDA section in LICENSE-binary, and the Java HTML Tidy License section. Verified: the checker reports zero STALE/ADDED across JVM, Python, and npm ecosystems against a fresh `sbt dist` / frontend build / pip install. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bobbai00
added a commit
to bobbai00/texera
that referenced
this pull request
Apr 23, 2026
PR apache#4475 was intended to remove jschardet via a `packageExtensions` rule, but the rule targets `@codingame/monaco-vscode-api@*` while package.json aliases that package as `vscode`. Yarn resolves the aliased ident in yarn.lock and never fires the rule — see the reopened apache#4461 for details. Dropping the LICENSE-binary entry here since jschardet is no longer declared in the desired bundle. The actual removal from the shipped artifact is tracked in apache#4461 and will be fixed separately. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
…aph (apache#4475) Strip transitive `jschardet` (LGPL-2.1, ASF Category X) declared by `@codingame/monaco-vscode-api`. It is only referenced by a dynamic `await import('jschardet')` inside the VS Code textfile encoding service, a code path Texera never exercises. Removing the declaration keeps it out of yarn.lock, node_modules, and the production bundle. ### Any related issues, documentation, discussions? Closes apache#4461 ### How was this PR tested? Tested manually. ### Was this PR authored or co-authored using generative AI tooling? No.
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
apache#4480) ### What changes were proposed in this PR? Attempt to fix the PR apache#4475 ### Any related issues, documentation, discussions? Closes apache#4461 ### How was this PR tested? ``` rm -rf frontend/node_modules yarn --cwd frontend install find frontend/node_modules -maxdepth 2 -name 'jschardet*' -type d grep -c 'jschardet' frontend/yarn.lock grep -B1 -A1 'jschardet' frontend/yarn.lock | head ``` ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 4.7) --------- Co-authored-by: Jiadong Bai <43344272+bobbai00@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip transitive
jschardet(LGPL-2.1, ASF Category X) declared by@codingame/monaco-vscode-api. It is only referenced by a dynamicawait import('jschardet')inside the VS Code textfile encoding service, a code path Texera never exercises. Removing the declaration keeps it out of yarn.lock, node_modules, and the production bundle.Any related issues, documentation, discussions?
Closes #4461
How was this PR tested?
Tested manually.
Was this PR authored or co-authored using generative AI tooling?
No.