Skip to content

fix(dependencies): remove jschardet from the frontend dependency graph#4480

Merged
bobbai00 merged 7 commits into
mainfrom
xinyuan-fix-license
Apr 23, 2026
Merged

fix(dependencies): remove jschardet from the frontend dependency graph#4480
bobbai00 merged 7 commits into
mainfrom
xinyuan-fix-license

Conversation

@aglinxinyuan

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Attempt to fix the PR #4475

Any related issues, documentation, discussions?

Closes #4461

How was this PR tested?

rm -rf frontend/node_modules
yarn --cwd frontend install
find frontend/node_modules -maxdepth 2 -name 'jschardet*' -type d
grep -c 'jschardet' frontend/yarn.lock
grep -B1 -A1 'jschardet' frontend/yarn.lock | head

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.7)

@aglinxinyuan aglinxinyuan requested a review from bobbai00 April 23, 2026 03:30
@aglinxinyuan aglinxinyuan self-assigned this Apr 23, 2026
@github-actions github-actions Bot added dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI labels Apr 23, 2026
@bobbai00 bobbai00 changed the title fix: Remove jschardet from the frontend dependency graph fix(dependencies): remove jschardet from the frontend dependency graph Apr 23, 2026
@bobbai00 bobbai00 enabled auto-merge (squash) April 23, 2026 05:11
@bobbai00 bobbai00 merged commit 7ccc97a into main Apr 23, 2026
11 checks passed
@bobbai00 bobbai00 deleted the xinyuan-fix-license branch April 23, 2026 05:18
bobbai00 added a commit to bobbai00/texera that referenced this pull request Apr 23, 2026
PR apache#4480 replaced the LGPL jschardet with an Apache-2.0 no-op stub
(frontend/tools/jschardet-stub) via the `resolutions` override. The
bundle still ships a package named `jschardet`, now under the stub's
Apache-2.0 license — 3rdpartylicenses.txt confirms.

LICENSE-binary should reflect what ships, so jschardet goes back —
this time under Apache-2.0 npm instead of ASF Category X.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
yangzhang75 pushed a commit to yangzhang75/texera that referenced this pull request Jun 22, 2026
apache#4480)

### What changes were proposed in this PR?
Attempt to fix the PR apache#4475

### Any related issues, documentation, discussions?
Closes apache#4461

### How was this PR tested?
```
rm -rf frontend/node_modules
yarn --cwd frontend install
find frontend/node_modules -maxdepth 2 -name 'jschardet*' -type d
grep -c 'jschardet' frontend/yarn.lock
grep -B1 -A1 'jschardet' frontend/yarn.lock | head
```

### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.7)

---------

Co-authored-by: Jiadong Bai <43344272+bobbai00@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Category X: jschardet pulled in by @codingame/monaco-vscode-api

2 participants