Treat trailing-slash exports keys as wildcards - #283
Open
morgan-coded wants to merge 1 commit into
Open
morgan-coded wants to merge 1 commit into
morgan-coded wants to merge 1 commit into
Conversation
A "./dir/" exports key is a folder mapping equivalent to "./dir/*", so mark it as a wildcard instead of resolving it as a literal subpath.
🦋 Changeset detectedLatest commit: 1ae5886 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exportskeys ending in/were treated as literal entrypoints and reported asNoResolutionunder node16 and bundler resolution.I treated those keys as wildcards alongside
*keys, so they display as(wildcard)and skip the resolution check.Explicit
--entrypointsand--include-entrypointsvalues ending in/receive the same wildcard treatment.The new folder-mapping test fails before the fix and passes with it, and the core and CLI suites pass without snapshot changes; this addresses #136.