Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/trailing-slash-wildcards.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@arethetypeswrong/core": patch
---

Treat trailing-slash `exports` keys as wildcard entrypoints.
3 changes: 2 additions & 1 deletion packages/core/src/internal/getEntrypointInfo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ function getEntrypointResolution(
resolutionKind: ResolutionKind,
entrypoint: string,
): EntrypointResolutionAnalysis {
if (entrypoint.includes("*")) {
// A trailing slash is the folder-mapping form of `./dir/*`
if (entrypoint.includes("*") || entrypoint.endsWith("/")) {
return { name: entrypoint, resolutionKind, isWildcard: true };
}
const moduleSpecifier = packageName + entrypoint.substring(1); // remove leading . before slash
Expand Down
29 changes: 29 additions & 0 deletions packages/core/test/getEntrypointInfo.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,33 @@ describe("getEntrypointInfo", () => {
assert("entrypoints" in result);
assert.deepStrictEqual(Object.keys(result.entrypoints), ["./features/*.js", "./browser"]);
});

test("treats trailing-slash exports keys as wildcards", async () => {
const result = await checkPackage(
createTestPackage({
"es/index.d.ts": "export {};",
"es/index.js": "export {};",
"index.d.ts": "export {};",
"index.js": "export {};",
"package.json": JSON.stringify({
name: "test",
version: "1.0.0",
exports: {
".": "./index.js",
"./es/": "./es/",
"./es/*": "./es/*.js",
},
}),
}),
);

assert("entrypoints" in result);
assert.deepStrictEqual(Object.keys(result.entrypoints), [".", "./es/", "./es/*"]);
assert(result.entrypoints["./es/"].isWildcard);
assert(Object.values(result.entrypoints["./es/"].resolutions).every((r) => r.isWildcard && !r.resolution));
assert.deepStrictEqual(
result.problems.filter((p) => "entrypoint" in p && p.entrypoint === "./es/"),
[],
);
});
});