Update to the new async abi - #1302
Merged
Merged
Conversation
Member
Author
|
Depends on bytecodealliance/wasm-tools#2198 |
dicej
reviewed
May 27, 2025
dicej
left a comment
dicej
left a comment
Collaborator
There was a problem hiding this comment.
LGTM once the tests pass and the /// TODO in subtask.rs is filled in.
This commit refactors the C/Rust bindings generators to handle the new async import ABI which allows up to 4 flat parameters instead of always having all parameters being indirect. Additionally the return pointer is omitted in the ABI if there are no return values.
alexcrichton
force-pushed
the
new-async-abi
branch
from
May 27, 2025 17:56
59d48c6 to
248fda0
Compare
alexcrichton
marked this pull request as ready for review
May 27, 2025 17:56
Member
Author
|
I'm really bad about going back and fixing my own TODOs.... Otherwise though I've confirmed locally that tests all pass with bytecodealliance/wasip3-prototyping#171 but I'll have to land this first, with failing async tests, before that PR can land. (and tests can't pass until the wasip3-prototyping PR lands). I'll follow-up with test fixes as necessary though if I missed something. |
alexcrichton
force-pushed
the
new-async-abi
branch
from
May 27, 2025 21:17
248fda0 to
204b706
Compare
alexcrichton
enabled auto-merge
May 27, 2025 21:17
dicej
approved these changes
May 27, 2025
psiegl
pushed a commit
to airbus-forks/wrpc
that referenced
this pull request
Jul 9, 2026
Merge upstream wit-bindgen 0.43.0 into the vendored bindgen subtree. - Bump wit-bindgen-core 0.42 -> 0.43 and wit-parser 0.230 -> 0.235 (no generator API churn this round). - Carry the new `tests/codegen/async-trait-function.wit` input (an exported resource with an `async func` method); wRPC generates it without changes (async functions are handled as their sync equivalents over the transport), so no skip-arm is needed. Non-carries (not applicable to wRPC, dropped from the merge): - another `wit-bindgen test` subcommand backend (`crates/test/src/cpp.rs`). - the async-ABI / future-stream refactors (bytecodealliance/wit-bindgen#1302/bytecodealliance/wit-bindgen#1315 future/stream ABI and names, bytecodealliance/wit-bindgen#1311 async trait function errors, bytecodealliance/wit-bindgen#1306 linear writes) and bytecodealliance/wit-bindgen@504dcd1a (disallow 0 in canonical-ABI `from_handle`) do not apply to wRPC's transport-stub generator. rust codegen (240) and go codegen (80) tests pass; `cargo clippy --workspace` and `cargo doc --workspace` are clean; wasmtime and all examples build. Assisted-by: claude:claude-opus-4-8 Upstream diff: bytecodealliance/wit-bindgen@v0.42.0...v0.43.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.