update future/stream ABIs and names - #1315
Merged
Merged
Conversation
This updates `wit-bindgen-rt` etc. to use (some of) the new ABI defined in WebAssembly/component-model#524. It covers everything in that PR _except_ the lifting and lowering changes to `future.{read,write}`, which we decided are more trouble than they're worth. I've tested this end-to-end with `wasip3-prototyping` and will soon post a corresponding PR there. Finally, `rustfmt` was complaining about using `gen` as a field name, so I took this opportunity to address that. Signed-off-by: Joel Dice <joel.dice@fermyon.com> fix rust codegen build errors Signed-off-by: Joel Dice <joel.dice@fermyon.com> snapshot Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Jun 9, 2025
| let mut gen = self.interface(resolve, true, Some(&wasm_import_module)); | ||
| gen.interface = Some((id, name)); | ||
| gen.define_interface_types(id); | ||
| let mut r#gen = self.interface(resolve, true, Some(&wasm_import_module)); |
Member
There was a problem hiding this comment.
I can do this in a follow-up but I'd prefer to avoid r#gen. I understand it's the machine-applicable way to migrate from one edition to another but no one really wants to either read or write r#gen over time so I'd prefer to go through and update things to generator or similar.
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Collaborator
Author
|
I'm going to try to fix the |
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
dicej
enabled auto-merge
June 9, 2025 23:12
psiegl
pushed a commit
to airbus-forks/wrpc
that referenced
this pull request
Jul 9, 2026
Merge upstream wit-bindgen 0.43.0 into the vendored bindgen subtree. - Bump wit-bindgen-core 0.42 -> 0.43 and wit-parser 0.230 -> 0.235 (no generator API churn this round). - Carry the new `tests/codegen/async-trait-function.wit` input (an exported resource with an `async func` method); wRPC generates it without changes (async functions are handled as their sync equivalents over the transport), so no skip-arm is needed. Non-carries (not applicable to wRPC, dropped from the merge): - another `wit-bindgen test` subcommand backend (`crates/test/src/cpp.rs`). - the async-ABI / future-stream refactors (bytecodealliance/wit-bindgen#1302/bytecodealliance/wit-bindgen#1315 future/stream ABI and names, bytecodealliance/wit-bindgen#1311 async trait function errors, bytecodealliance/wit-bindgen#1306 linear writes) and bytecodealliance/wit-bindgen@504dcd1a (disallow 0 in canonical-ABI `from_handle`) do not apply to wRPC's transport-stub generator. rust codegen (240) and go codegen (80) tests pass; `cargo clippy --workspace` and `cargo doc --workspace` are clean; wasmtime and all examples build. Assisted-by: claude:claude-opus-4-8 Upstream diff: bytecodealliance/wit-bindgen@v0.42.0...v0.43.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
wit-bindgen-rtetc. to use (some of) the new ABI defined in WebAssembly/component-model#524. It covers everything in that PR except the lifting and lowering changes tofuture.{read,write}, which we decided are more trouble than they're worth.I've tested this end-to-end with
wasip3-prototypingand will soon post a corresponding PR there.Finally,
rustfmtwas complaining about usinggenas a field name, so I took this opportunity to address that.