Skip to content

feat: isInaccessible API form RTL/DTL - #1128

Merged
mdjastrzebski merged 14 commits into
mainfrom
feat/is-inaccessible-api
Sep 23, 2022
Merged

feat: isInaccessible API form RTL/DTL#1128
mdjastrzebski merged 14 commits into
mainfrom
feat/is-inaccessible-api

Conversation

@mdjastrzebski

@mdjastrzebski mdjastrzebski commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Implement isInaccessible API from DTL (re-exported from RTL).

This should be a useful building block for features as:

To Do

  • Implement & export basic API
  • Add style-based checks (display: none & opacity: 0) + tests
  • Add iOS accessibilityElementsHidden with tests
  • Add Android importantForAccessibility with tests
  • Add iOS: accessibilityViewIsModal with tests
  • Write docs

Test plan

All checks should pass.

@mdjastrzebski mdjastrzebski changed the title feat: isInaccessible api form RTL/DTL feat: isInaccessible API form RTL/DTL Sep 19, 2022
thymikee
thymikee reviewed Sep 19, 2022
View reviewed changes
Comment thread src/helpers/accessiblity.ts Outdated
thymikee
thymikee reviewed Sep 19, 2022
View reviewed changes
Comment thread src/helpers/accessiblity.ts Outdated
@mdjastrzebski
mdjastrzebski marked this pull request as ready for review September 20, 2022 14:04
@mdjastrzebski mdjastrzebski mentioned this pull request Sep 20, 2022
Closed
AugustinLF
AugustinLF requested changes Sep 21, 2022
View reviewed changes
Comment thread website/docs/API.md Outdated
Comment thread website/docs/API.md Outdated
Comment thread src/helpers/component-tree.ts
@mdjastrzebski @AugustinLF
Update website/docs/API.md
6c33584 
Co-authored-by: Augustin Le Fèvre <augustin.le-fevre@klarna.com>
@mdjastrzebski
mdjastrzebski marked this pull request as draft September 22, 2022 15:54
@mdjastrzebski
mdjastrzebski marked this pull request as ready for review September 23, 2022 10:39
thymikee
thymikee reviewed Sep 23, 2022
View reviewed changes
Comment thread website/docs/API.md Outdated
@mdjastrzebski

mdjastrzebski commented Sep 23, 2022

Copy link
Copy Markdown
Member Author

@AugustinLF I'd like to include this in the upcoming release, could you review it again?

AugustinLF
AugustinLF approved these changes Sep 23, 2022
View reviewed changes

@AugustinLF AugustinLF left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mdjastrzebski
mdjastrzebski merged commit fa21fc5 into main Sep 23, 2022
@mdjastrzebski
mdjastrzebski deleted the feat/is-inaccessible-api branch September 23, 2022 17:33
@mdjastrzebski

mdjastrzebski commented Sep 26, 2022

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 11.2.0 🎉

@mdjastrzebski mdjastrzebski mentioned this pull request Sep 27, 2022
Merged
@mdjastrzebski mdjastrzebski mentioned this pull request Oct 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AugustinLF AugustinLF AugustinLF approved these changes
@thymikee thymikee Awaiting requested review from thymikee

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdjastrzebski @thymikee @AugustinLF