Skip to content

feature: configure API from DTL - #1141

Merged
mdjastrzebski merged 9 commits into
mainfrom
feature/configure-api
Sep 27, 2022
Merged

feature: configure API from DTL#1141
mdjastrzebski merged 9 commits into
mainfrom
feature/configure-api

Conversation

@mdjastrzebski

@mdjastrzebski mdjastrzebski commented Sep 27, 2022

Copy link
Copy Markdown
Member

Summary

Implement configure API based on similar API in DTL.

Added initial option for asyncWaitTimeout.

Test plan

  • Added tests for config module functions
  • Added tests for waitFor consuming asyncWaitTimeout option

@mdjastrzebski mdjastrzebski mentioned this pull request Sep 27, 2022
Closed
@mdjastrzebski
mdjastrzebski merged commit 932c547 into main Sep 27, 2022
@mdjastrzebski
mdjastrzebski deleted the feature/configure-api branch September 27, 2022 14:18
thymikee
thymikee approved these changes Sep 27, 2022
View reviewed changes

@thymikee thymikee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also implement defaultHidden, right? Looks good though

Comment thread src/pure.ts

export { act };
export { cleanup };
export { configure, resetToDefaults } from './config';

@thymikee thymikee Sep 27, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is resetToDefaults exported from DTL? Couldn't find it on their docs

@mdjastrzebski mdjastrzebski Sep 27, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not, only configure is, but I think it's good to have that for testinging convenience. Wdyt?

@mdjastrzebski

mdjastrzebski commented Sep 27, 2022

Copy link
Copy Markdown
Member Author

re defaultHidden: we first need to merge #1064, as it contains the hidden query options, and afaik defaultHidden is just the default value of that option.

@thymikee

thymikee commented Sep 27, 2022

Copy link
Copy Markdown
Member

re defaultHidden: we first need to merge #1064, as it contains the hidden query options, and afaik defaultHidden is just the default value of that option.

Huh, it's opened for so long I thought it's already in 🙈

@mdjastrzebski

mdjastrzebski commented Sep 27, 2022

Copy link
Copy Markdown
Member Author

It should be much easier done now when we have isInaccessible #1128 , which is the core logic behind hidden flag.

@thymikee

thymikee commented Sep 27, 2022

Copy link
Copy Markdown
Member

Definitely! And please don't get me wrong, I'm not expecting to rush things here :)

@mdjastrzebski mdjastrzebski mentioned this pull request Sep 30, 2022
Closed
@AugustinLF AugustinLF mentioned this pull request Oct 9, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thymikee thymikee thymikee approved these changes
@AugustinLF AugustinLF AugustinLF approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdjastrzebski @thymikee @AugustinLF