[v12] refactor: exclude hidden elements by defaults - #1317
Merged
Conversation
mdjastrzebski
requested review from
AugustinLF,
MattAgn,
pierrezimmermannbam and
thymikee
February 14, 2023 21:57
mdjastrzebski
changed the title
mdjastrzebski
changed the title
pierrezimmermannbam
approved these changes
Feb 15, 2023
mdjastrzebski
force-pushed
the
refactor/exclude-hidden-elements
branch
from
February 16, 2023 13:30
393e065 to
19e1cdc
Compare
thymikee
reviewed
Feb 17, 2023
thymikee
reviewed
Feb 17, 2023
thymikee
reviewed
Feb 17, 2023
thymikee
approved these changes
Feb 17, 2023
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Codecov ReportBase: 96.09% // Head: 96.09% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v12 #1317 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 49 49
Lines 3275 3280 +5
Branches 489 492 +3
=======================================
+ Hits 3147 3152 +5
Misses 128 128
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mdjastrzebski
added a commit
that referenced
this pull request
Feb 20, 2023
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
mdjastrzebski
added a commit
that referenced
this pull request
Mar 8, 2023
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultIncludeHiddenElements: falseTest plan
All checks should pass. Pls review testing code.