v12 release

[mdjastrzebski]

Summary

This is feature branch for merging particular v12 features/toggles/changes. It will be merged to main branch when v12 is ready to release.

• enable changes hidden behind useBreakingChanges flag [v12] refactor: enable all breaking changes #1313
• make includeHiddenElements: false by default [v12] refactor: exclude hidden elements by defaults #1317
• v12 migration doc

Issues & fixes:

• toBeOnTheScreen doesn't work with v12.0.0-rc.0 #1338 / fix: toBeOnTheScreen RNTL v12 testing-library/jest-native#151
• 'container' property has been renamed to 'UNSAFE_root' #1350 / fix: container enumeration #1352
• Type error when upgrading from 11.5 to 11.5.1 with skipLibCheck: false and using RN 0.70 #1351 / fix: resolve AccessibilityState import issue due to types migration to react-native package #1355

Test plan

All checks should pass.

[thymikee]

Do we have a release plan already? Starting with some RC or going straight to the stable release channel?

[mdjastrzebski]

I would like to RC first, as we have some breaking changes. Going this way might help use catch some potential errors before reaching general public. IIRC @AugustinLF offered to test RC on his project.

[pierrezimmermannbam]

I think a RC is a good idea, I'll also try the latest version on my project

[mdjastrzebski]

I've just releases v12.0.0-rc.0. Our first RC. 🎉

@AugustinLF @pierrezimmermannbam @MattAgn could you take it for a spin, and see if it works fine with our test suits?

[pierrezimmermannbam]

I just tried it on my current project, it doesn't work with toBeOnTheScreen matcher, I opened an issue #1338

[mdjastrzebski]

@pierrezimmermannbam Jest Native 5.4.2 is out with the fix!

[mdjastrzebski]

@pierrezimmermannbam how about other issues beside toBeOnTheScreen() issue? Where there any or all green?

[pierrezimmermannbam]

@mdjastrzebski I'll test with newer version of jest-native because it may have hidden other issues but so far I haven't seen other issues

[pierrezimmermannbam]

No other issues on my project, I've tested it on an older project as well, just got some byRole queries not working because they targeted non accessible elements 🎉

[AugustinLF]

Back from vacation, I'll try to update, will keep you updated in the upcoming days :)

[mdjastrzebski]

I've just released RC 1 with fix for #1350.

[AugustinLF]

I tested the RC, and apart from the type issue I mentioned in #1351 and the container problem of #1350, nothing unexpected (it did caught a few accessibility errors, and improved some of our tests that were messy because of accessible={false} nested touchables, so overall, really happy with the release :)

[mdjastrzebski]

Just released RC 2 🎉

[mdjastrzebski]

@AugustinLF, @pierrezimmermannbam, @MattAgn the RC 2 seems to be ready from my perspective, all reported issues (#1338, ) have been fixed.

Do you have any more tests to perform? Are you aware of any more issues?

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (c4d36e4) 96.12% compared to head (be0b16a) 96.13%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   96.12%   96.13%           
=======================================
  Files          49       49           
  Lines        3359     3314   -45     
  Branches      503      491   -12     
=======================================
- Hits         3229     3186   -43     
+ Misses        130      128    -2     

Impacted Files	Coverage Δ
src/queries/text.ts	100.00% <ø> (+2.10%)	⬆️
src/screen.ts	100.00% <ø> (ø)
src/config.ts	100.00% <100.00%> (ø)
src/helpers/accessiblity.ts	100.00% <100.00%> (ø)
src/queries/displayValue.ts	100.00% <100.00%> (ø)
src/queries/placeholderText.ts	100.00% <100.00%> (ø)
src/queries/role.ts	100.00% <100.00%> (ø)
src/render.tsx	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mdjastrzebski]

If there are no more issues and/or comments regarding this RC, let's plan release for next Tuesday, Mar 14 😄