fix: resolve AccessibilityState import issue due to types migration to react-native package - #1355
Conversation
react-native package
|
@thymikee perhaps you'll have some alternative solution to the exposing RN types issue during migration from |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v12 #1355 +/- ##
==========================================
+ Coverage 96.10% 96.13% +0.03%
==========================================
Files 49 49
Lines 3283 3314 +31
Branches 491 491
==========================================
+ Hits 3155 3186 +31
Misses 128 128
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
We're also using |
|
@pierrezimmermannbam true, but somehow we use it only internally and do not re-export it. When searching in |
|
Yep the errors I saw were only pointing out to |
|
Oh indeed we're redeclaring the type |
|
Just released RC2 with this fix. @AugustinLF let me know if this fixes the error, then I will backport it to v11 versions on |
|
It works! |
Summary
Duplicate
AccessibilityStatetype asAccessibilityStateMatchertype in order to avoid issues occurring during migration period from@types/react-nativeto built-inreact-nativetypes. See #1351 for details.This fix will be first applied to v12 branch to verify that it fixes the issue, and later will be backported to v11.
Resolves #1351
Test plan
Verification by @AugustinLF after v12 RC2 is released.