chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provider#4092
Conversation
🦋 Changeset detectedLatest commit: 7fa822c The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
left a comment
There was a problem hiding this comment.
Minor feedback about elements
| case 'web3_coinbase_signature': { | ||
| const signature = fields.get('signature')?.value as string | undefined; | ||
| assertIsDefined(signature, 'Web3 Coinbase signature'); | ||
|
|
||
| attemptParams = { | ||
| strategy, | ||
| signature, | ||
| } satisfies Web3Attempt; | ||
|
|
||
| break; | ||
| } |
There was a problem hiding this comment.
Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?
There was a problem hiding this comment.
In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider
| @@ -0,0 +1,2 @@ | |||
| --- | |||
There was a problem hiding this comment.
Shouldn't we add a changeset about these changes?
There was a problem hiding this comment.
I was thinking to avoid adding one as we never really released the Coinbase provider, so in some way we revert the changes. But sure let me add one
|
|
||
| type EIP6963AnnounceProviderEvent = CustomEvent; | ||
| type InjectedWeb3Provider = MetamaskWeb3Provider | CoinbaseWeb3Provider; | ||
| type InjectedWeb3Provider = MetamaskWeb3Provider; |
There was a problem hiding this comment.
❓ We don't need CoinbaseWalletWeb3Provider here?
There was a problem hiding this comment.
No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk
…ed Coinbase web3 provider The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them
7841b21 to
0fc8d40
Compare
Description
The current 'coinbase' web3 provider has been replaced by a generic 'coinbase_wallet' provider which supports both Smart Wallets and the Coinbase Wallet browser extension. The feature is not yet released, so it's safe to remove them
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change