-
Notifications
You must be signed in to change notification settings - Fork 454
chore(clerk-js,types,clerk-react,elements): Drop coinbase web3 provider #4092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| "@clerk/clerk-js": patch | ||
| "@clerk/elements": patch | ||
| "@clerk/clerk-react": patch | ||
| "@clerk/types": patch | ||
| --- | ||
|
|
||
| Drop support for deprecated Coinbase Web3 provider |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -448,17 +448,6 @@ export const SignInFirstFactorMachine = SignInVerificationMachine.provide({ | |
|
|
||
| break; | ||
| } | ||
| case 'web3_coinbase_signature': { | ||
| const signature = fields.get('signature')?.value as string | undefined; | ||
| assertIsDefined(signature, 'Web3 Coinbase signature'); | ||
|
|
||
| attemptParams = { | ||
| strategy, | ||
| signature, | ||
| } satisfies Web3Attempt; | ||
|
|
||
| break; | ||
| } | ||
|
Comment on lines
-451
to
-461
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are we removing the elements support for Coinbase completely or are we replacing it with Coinbase Wallet ? Will this be done in a follow up PR ?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In this PR we are removing the support for the deprecated Coinbase completely. There is a separate PR #4103 to handle the new Coinbase Wallet provider |
||
| case 'web3_coinbase_wallet_signature': { | ||
| const signature = fields.get('signature')?.value as string | undefined; | ||
| assertIsDefined(signature, 'Web3 Coinbase Wallet signature'); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ We don't need
CoinbaseWalletWeb3Providerhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because CoinbaseWallet is not an injected provider but it's handled via the coinbase wallet sdk