Fix the --path option on gherkin:snippets - #1790
Merged
Merged
Conversation
Contributor
Author
|
Please note that the Travis build fail wasn't caused by this PR, the WebDriver tests failed with a filename that is too long for some reason. |
Contributor
Author
|
@DavertMik Do you think maybe we could merge this fix in for the next release? Also, if you have time, I'd love to hear your feedback on #1801 and #1803 :) |
DavertMik
approved these changes
Jul 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1688 added support to direct new snippets to a specific file, but forgot to add the
--pathoption to the command line parser. Without this fix,codeceptjs gherkin:snippets --path=fooresults in an error "error: unknown option `--path'"