Fix for snippets command with a .feature file that has special characters - #1801
Merged
DavertMik merged 3 commits intoJul 27, 2019
Merged
Conversation
… steps with Gherkin special characters Instead of creating strings, create regular expressions that will match This fixes the problem where the generated snippets won't match the steps from the original .feature file
houndci-bot
reviewed
Jul 24, 2019
| .map((step) => { | ||
| return ` | ||
| ${step.type}('${step}', () => { | ||
| ${step.type}(${step.regexp ? '/^' + step + '$/' : "'" + step + "'"}, () => { |
There was a problem hiding this comment.
Unexpected string concatenation prefer-template
Contributor
Author
|
Note: the CircleCI failure was not due to this PR. CircleCI failed with a timeout. |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue when running snippets command with a .feature file that has steps with Gherkin special characters (any of { } ( ) / )
Instead of creating strings, create regular expressions that will match
This fixes the problem where the generated snippets won't match the steps from the original .feature file