Skip to content

fix: rename Entity::setAttributes() to avoid name collision - #5763

Closed
kenjis wants to merge 1 commit into
codeigniter4:developfrom
kenjis:fix-entity-column-attributes
Closed

fix: rename Entity::setAttributes() to avoid name collision#5763
kenjis wants to merge 1 commit into
codeigniter4:developfrom
kenjis:fix-entity-column-attributes

Conversation

@kenjis

@kenjis kenjis commented Mar 3, 2022

Copy link
Copy Markdown
Member

Description
Fixes #5762

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them breaking change Pull requests that may break existing functionalities labels Mar 3, 2022
@kenjis kenjis mentioned this pull request Mar 3, 2022
Closed
mostafakhudair
mostafakhudair reviewed Mar 3, 2022
View reviewed changes
Comment thread system/Entity/Entity.php
* @return $this
*/
public function setAttributes(array $data)
public function injectRawData(array $data)

@mostafakhudair mostafakhudair Mar 3, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing public function is BC, isn't it?

@kenjis kenjis Mar 4, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I added beraking change label.

@kenjis
kenjis force-pushed the fix-entity-column-attributes branch from e1b319c to e583b34 Compare March 4, 2022 00:52
@kenjis kenjis mentioned this pull request Mar 7, 2022
Closed
5 tasks
@kenjis
kenjis marked this pull request as draft June 23, 2022 01:06
@MGatner

MGatner commented Sep 16, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

@kenjis Is this still relevant after #5809?

@kenjis kenjis added next major version? Read this for a relevant v5 idea and removed bug Verified issues on the current code behavior or pull requests that will fix them labels Sep 17, 2022
@kenjis

kenjis commented Sep 17, 2022

Copy link
Copy Markdown
Member Author

At least, this PR won't be merged into 4.x.
But I want to fix this bad design in the future.

@najdanovicivan

najdanovicivan commented Jan 27, 2023

Copy link
Copy Markdown
Contributor

I like the injectRawData naming. It can be merged into 4.x if setAttributes is still kept as deprecated so that we can upgrade before the next major version.

@kenjis kenjis mentioned this pull request Feb 1, 2023
Merged
5 tasks
@kenjis

kenjis commented Feb 1, 2023

Copy link
Copy Markdown
Member Author

I sent PR #7208

@kenjis kenjis closed this Feb 1, 2023
@kenjis
kenjis deleted the fix-entity-column-attributes branch February 11, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mostafakhudair mostafakhudair mostafakhudair left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change Pull requests that may break existing functionalities next major version? Read this for a relevant v5 idea

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Entity can't handle column named attributes

4 participants

@kenjis @MGatner @najdanovicivan @mostafakhudair