Conversation
Add _set*() method as a setter.
kenjis
added
the
bug
Member
|
I like this solution better, but let's wrap up the Issue conversation first. I think it is quite possible that someone is using |
Comment on lines
+447
to
+456
| // If a "`_set` + $key" method exists, it is a setter. | ||
| if (method_exists($this, '_' . $method)) { | ||
| $this->{$method}($value); | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| // If a "`set` + $key" method exists, it is also a setter. | ||
| // But setAttributes() is not a setter for this. | ||
| if ($key !== 'attributes' && method_exists($this, $method)) { |
Contributor
There was a problem hiding this comment.
Suggested change
| // If a "`_set` + $key" method exists, it is a setter. | |
| if (method_exists($this, '_' . $method)) { | |
| $this->{$method}($value); | |
| return $this; | |
| } | |
| // If a "`set` + $key" method exists, it is also a setter. | |
| // But setAttributes() is not a setter for this. | |
| if ($key !== 'attributes' && method_exists($this, $method)) { | |
| // If a "`_set` + $key" method exists, it is a setter, or | |
| // if a "`set` + $key" method exists, it is also a setter. | |
| // But setAttributes() is not a setter for this. | |
| if (method_exists($this, '_' . $method) || ($key !== 'attributes' && method_exists($this, $method))) { |
Contributor
There was a problem hiding this comment.
Let's make code shorter,
Member
Author
There was a problem hiding this comment.
Thanks, I found a bug in my code.
Why do you like shorter code?
kenjis
marked this pull request as draft
March 18, 2022 08:14
Member
|
Maybe mark this one to revisit for version 5? |
Member
Author
kenjis
added
the
breaking change
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5762
Supersede #5763
_set+ key" for a attributeChecklist: