Skip to content

docs: Suppress phpstan error in AutoRouterImproved - #7649

Closed
kenjis wants to merge 1 commit into
codeigniter4:4.4from
kenjis:suppress-phpstan-error-AutoRouterImproved
Closed

kenjis wants to merge 1 commit into
codeigniter4:4.4from
kenjis:suppress-phpstan-error-AutoRouterImproved

Conversation

@kenjis

@kenjis kenjis commented Jul 3, 2023

Copy link
Copy Markdown
Member

Description
The following error is a false positive.
See AutoRouterImprovedTest::testFindsControllerAndMethodAndParam().

  ------ ---------------------------------------------------------------
  Line   system/Router/AutoRouterImproved.php
 ------ ---------------------------------------------------------------
  301    Strict comparison using !== between null and null will always
         evaluate to false.
 ------ ---------------------------------------------------------------

https://github.com/codeigniter4/CodeIgniter4/actions/runs/5449192482/jobs/9913186865

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

The following error is false positive.
See AutoRouterImprovedTest::testFindsControllerAndMethodAndParam().

  ------ ---------------------------------------------------------------
  Line   system/Router/AutoRouterImproved.php
 ------ ---------------------------------------------------------------
  301    Strict comparison using !== between null and null will always
         evaluate to false.
 ------ ---------------------------------------------------------------
@kenjis kenjis added the 4.4 label Jul 3, 2023
@kenjis
kenjis marked this pull request as draft July 6, 2023 04:27
@kenjis

kenjis commented Jul 7, 2023

Copy link
Copy Markdown
Member Author

Closed by #7650

@kenjis kenjis closed this Jul 7, 2023
@kenjis
kenjis deleted the suppress-phpstan-error-AutoRouterImproved branch July 7, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant