refactor: extract DefinedRouteCollector

[kenjis]

Description

• extract DefinedRouteCollector

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• [] User guide updated
• Conforms to style guide

[paulbalandan]

is this intended to be extended? can this be made final?

[kenjis]

Added.

[paulbalandan]

Please make this test name descriptive. If using --test-dox option this test will have an empty name.

[kenjis]

I forgot to rename it. Done.

[paulbalandan]

Can you add the signature of the Generator in the PHPDoc so that it can be used by IDEs?

[kenjis]

Done.

[MGatner]

That sig begs the question: is it worth introducing a value object at some point for better definition?

[kenjis]

The data structure of a route is complex, so it would be easier to understand if it were a class.

[MGatner]

PHPStan is unhappy.

[kenjis]

PHPStan is unhappy.

See #7649

[ChibuezeAgwuDennis]

in addition to this when a new RouteCollection library is created implementing the RouteCollectionInterface this throw an exception of

CodeIgniter\Router\DefinedRouteCollector::__construct(): Argument #1 ($routes) must be of type CodeIgniter\Router\RouteCollection, App\Libraries\Routing\RouteCollection given, called in C:\laragon\www\sebaadev\system\Debug\Toolbar\Collectors\Routes.php on line 103

@kenji I suggest you replace CodeIgniter\Router\RouteCollection to this CodeIgniter\Router\RouteCollectionInterface and use more of Services::routes()

I edited the core code of DefinedRouteCollector to this and it worked

    private RouteCollectionInterface $routeCollection;

    public function __construct(RouteCollectionInterface $routes)
    {
        $this->routeCollection = $routes;
    }

[kenjis]

@ChibuezeAgwuDennis We can't. Because RouteCollectionInterface is broken.
It does not have getRoutesOptions().
To do so, we need to fix RouteCollectionInterface first.

[ChibuezeAgwuDennis]

@ChibuezeAgwuDennis We can't. Because RouteCollectionInterface is broken.
It does not have getRoutesOptions().
To do so, we need to fix RouteCollectionInterface first.

Okay i understand but it can be fixed since getRoutesOptions() are implemented on the RouteCollection class.