Conversation
kenjis
force-pushed
the
fix-phpstan-errors
branch
from
July 21, 2023 01:09
b3beb4c to
b5bea41
Compare
kenjis
marked this pull request as draft
July 21, 2023 01:09
kenjis
force-pushed
the
fix-phpstan-errors
branch
from
July 21, 2023 02:06
b5bea41 to
66429c3
Compare
kenjis
marked this pull request as ready for review
July 21, 2023 02:06
Member
|
Since the |
kenjis
commented
Jul 21, 2023
| 'message' => '#^Method CodeIgniter\\\\Exceptions\\\\FrameworkException\\:\\:forInvalidDirectory\\(\\) has no return type specified\\.$#', | ||
| 'count' => 1, | ||
| 'path' => __DIR__ . '/system/Exceptions/FrameworkException.php', | ||
| ]; |
Member
Author
There was a problem hiding this comment.
@paulbalandan The return type should be static, but we cannot use it yet:
CodeIgniter4/system/Exceptions/FrameworkException.php
Lines 36 to 39 in dec4b71
Member
There was a problem hiding this comment.
Then a PHPDoc should suffice.
kenjis
marked this pull request as draft
July 21, 2023 03:15
3 tasks
Member
Author
|
Closed by #7723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #7722Description
Update phpstan-baseline.php for #7713
Fixes https://github.com/codeigniter4/CodeIgniter4/actions/runs/5617352335/job/15221317246
Checklist: