Skip to content

refactor: [4.4] add types for phpstan - #7723

Merged
kenjis merged 3 commits into
codeigniter4:4.4from
kenjis:refactor-add-return-types-4.4
Jul 22, 2023
Merged

refactor: [4.4] add types for phpstan#7723
kenjis merged 3 commits into
codeigniter4:4.4from
kenjis:refactor-add-return-types-4.4

Conversation

@kenjis

@kenjis kenjis commented Jul 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description
Supersedes #7721
See #7713

  • add types to new classes or private methods

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added 4.4 refactor Pull requests that refactor code labels Jul 21, 2023
@kenjis
kenjis merged commit df5973b into codeigniter4:4.4 Jul 22, 2023
@kenjis
kenjis deleted the refactor-add-return-types-4.4 branch July 22, 2023 07:59
@kenjis kenjis mentioned this pull request Jul 22, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes
@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis @MGatner @paulbalandan