Fix: Routing::loadRoutes() in windows do not validate correctly $routesFiles - #7930
Merged
Merged
Conversation
samsonasik
approved these changes
Sep 12, 2023
kenjis
reviewed
Sep 12, 2023
Member
Since when? That doesn't seem right. |
Member
|
@MGatner that ignored message to be removed from baseline |
kenjis
reviewed
Sep 14, 2023
pjsde
force-pushed
the
fix-routing
branch
2 times, most recently
from
September 14, 2023 08:48
00b4aff to
193e14d
Compare
paulbalandan
approved these changes
Sep 15, 2023
kenjis
approved these changes
Sep 15, 2023
Member
|
@pjsde Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This occours because the argument definition is
string $routesFile = APPPATH . 'Config/Routes.php'(using an slash/) and in the constructor$this->routeFilesis initialized withrealpath($routesFile).When validating if
$routesFileexist in the$routeFilesarray it do not exist, so add it to the$routeFiles[]duplicating the path.expected:
result:
Checklist: