chore: add file sync daemon tests - #129
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (1)
- Makefile: Language not supported
Comments suppressed due to low confidence (2)
Coder-Desktop/VPNLib/FileSync/FileSyncManagement.swift:22
- The syntax 'do throws(DaemonError)' is not valid in Swift. Replace it with a standard 'do {' block for error handling.
do throws(DaemonError) {
Coder-Desktop/VPNLib/FileSync/FileSyncManagement.swift:20
- [nitpick] Consider renaming the parameter 'arg' to a more descriptive name such as 'request' for improved clarity.
func createSession(arg: CreateSyncSessionRequest) async throws(DaemonError) {
deansheather
approved these changes
Apr 7, 2025
ethanndickson
force-pushed
the
ethan/file-sync-daemon-tests
branch
from
April 8, 2025 03:25
2b10e0e to
e48c66a
Compare
ethanndickson
force-pushed
the
ethan/remote-file-picker
branch
from
April 8, 2025 03:25
968fa7b to
a553fb6
Compare
ethanndickson
force-pushed
the
ethan/file-sync-daemon-tests
branch
2 times, most recently
from
April 9, 2025 03:20
a74e32f to
0cae729
Compare
Member
Author
ethanndickson
changed the base branch from
ethan/remote-file-picker
to
graphite-base/129
April 9, 2025 10:01
ethanndickson
force-pushed
the
ethan/file-sync-daemon-tests
branch
from
April 9, 2025 10:02
0cae729 to
e2a0f1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are just regression tests for the core file sync daemon functionality.
Also has sync sessions ignore VCS directories by default, as per the file sync RFC.