Skip to content

feat: add remote folder picker to file sync GUI - #127

Merged
ethanndickson merged 6 commits into
mainfrom
ethan/remote-file-picker
Apr 9, 2025
Merged

ethanndickson merged 6 commits into
mainfrom
ethan/remote-file-picker

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Apr 3, 2025

Copy link
Copy Markdown
Member

Closes #65.

pickerexample_small.mp4
pickerstresstest.mov
image

ethanndickson commented Apr 3, 2025

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson
ethanndickson marked this pull request as ready for review April 3, 2025 07:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a remote folder picker to the file sync GUI by integrating new API endpoints and views to enable users to select remote directories.

  • Adds Sendable conformance to the Client model and implements methods for listing agent directories in AgentLS.swift.
  • Introduces a FilePicker view, its associated model, and test cases to validate file picking logic.
  • Updates the FileSync session modal to include a remote folder picker button alongside an enhanced UI.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Coder-Desktop/CoderSDK/Client.swift Added Sendable conformance to improve thread-safety.
Coder-Desktop/CoderSDK/AgentLS.swift Introduced LS request/response models and a new directory listing function.
Coder-Desktop/Coder-DesktopTests/Util.swift Added the eventually helper function for async testing.
Coder-Desktop/Coder-DesktopTests/FilePickerTests.swift Added tests for error handling, file loading, and directory expansion in the file picker.
Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncSessionModal.swift Updated the file sync session modal UI to include remote folder picking capability.
Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift Implemented the FilePicker view, its model, and helper extensions to support file selection.
Files not reviewed (1)
  • Coder-Desktop/Coder-Desktop/Info.plist: Language not supported
Comments suppressed due to low confidence (3)

Coder-Desktop/CoderSDK/AgentLS.swift:31

  • [nitpick] Consider renaming 'absolute_path' to 'absolutePath' to follow Swift naming conventions; if these property names are tied to API keys, consider using CodingKeys for mapping.
public let absolute_path: [String]

Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncSessionModal.swift:16

  • [nitpick] Consider renaming 'pickingRemote' to 'isPickingRemote' to improve clarity and better align with SwiftUI naming conventions.
@State private var pickingRemote: Bool = false

Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift:203

  • [nitpick] Consider renaming the parameter 'dir' to 'isDirectory' to enhance readability and clarity.
dir: Bool = false

Comment thread Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift Outdated
Comment thread Coder-Desktop/CoderSDK/AgentLS.swift Outdated
@ethanndickson
ethanndickson force-pushed the ethan/remote-file-picker branch from 968fa7b to a553fb6 Compare April 8, 2025 03:25
Comment thread Coder-Desktop/CoderSDK/AgentClient.swift
Comment thread Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift
Comment thread Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift Outdated
Comment thread Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift Outdated
Comment thread Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift
Comment thread Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift Outdated
Comment thread Coder-Desktop/Coder-Desktop/Views/FileSync/FilePicker.swift

ethanndickson commented Apr 9, 2025

Copy link
Copy Markdown
Member Author

Merge activity

  • Apr 9, 6:01 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 9, 6:01 AM EDT: A user merged this pull request with Graphite.

@ethanndickson
ethanndickson merged commit de604d7 into main Apr 9, 2025
@ethanndickson
ethanndickson deleted the ethan/remote-file-picker branch April 9, 2025 10:01
@ethanndickson ethanndickson self-assigned this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add remote folder picker to file sync GUI

4 participants