feat: add hidden files toggle to remote file picker - #269
Draft
ethanndickson wants to merge 2 commits into
Draft
ethanndickson wants to merge 2 commits into
ethanndickson wants to merge 2 commits into
Conversation
ethanndickson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remote file picker has filtered out dotfiles since #127, and I don't think there was a strong reason for it. It does mean paths like
.mux/worktrees/<name>can't be selected as the remote directory for a file sync session.To fix, this PR adds a
Show hidden filescheckbox to the bottom of the picker, persisted via@AppStorage, and moves the filtering out ofLSResponse.toModelsand into the views. The agent already returns dotfiles, so toggling it just filters what's already loaded rather than refetching. If a hidden entry is selected whilst the toggle is turned off, we clear the selection soSelectcan't submit something that's no longer visible.