Allow Unicode letters in bundle variable reference paths#5532
Merged
Conversation
Collaborator
|
Commit: 656cf21
24 interesting tests: 15 SKIP, 7 KNOWN, 2 flaky
Top 28 slowest tests (at least 2 minutes):
|
radakam
force-pushed
the
unicode-variable-reference-support
branch
from
3be6244 to
66340e6
Compare
radakam
force-pushed
the
unicode-variable-reference-support
branch
from
c252eb2 to
b7365b3
Compare
denik
reviewed
Jun 11, 2026
radakam
force-pushed
the
unicode-variable-reference-support
branch
from
9087e76 to
8865ee7
Compare
denik
reviewed
Jun 11, 2026
Extend ${...} segment matching to accept Unicode letters (not just ASCII)
across Go, Python, and JSON Schema validation, with a shared reference_vectors
contract to keep the three implementations in sync.
This adds a resource_deps fixture that validates `${resources...}` resolution when job keys use Unicode characters, covering a reviewer-requested acceptance scenario.
Run plan, deploy, and summary in the unicode resource reference acceptance case so it validates runtime behavior beyond config validation.
radakam
force-pushed
the
unicode-variable-reference-support
branch
from
3639ada to
7009435
Compare
denik
approved these changes
Jun 11, 2026
Prefix unicode resource-deps acceptance commands with trace so fixture output clearly separates validate, plan, deploy, and summary steps per review feedback.
Collaborator
|
Commit: ed5cf3a
433 interesting tests: 394 MISS, 22 FAIL, 6 KNOWN, 4 PANIC, 3 RECOVERED, 2 flaky, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-tagging Bot
added a commit
that referenced
this pull request
Jun 17, 2026
## Release v1.4.0 ### CLI * Improved error messages for `ssh connect`: when an SSH connection attempt fails, the client now fetches and prints the server's recent error logs ([#5555](#5555)). * Increase the SSH server startup timeout from 10 to 45 minutes when a GPU accelerator is requested via `databricks ssh connect --accelerator` ([#5569](#5569)). * Fix authentication falling back to the default profile in `.databrickscfg` when a host is already configured via the environment (e.g. `DATABRICKS_HOST` with `DATABRICKS_TOKEN`) ([#5616](#5616)). * ssh: fix opening remote environment in Cursor, which previously hung on default-extension install and never opened the editor ([#5619](#5619)). * Improve the error shown when `databricks labs install` cannot find a project's `labs.yml`: the message now explains that either the requested version does not exist or the project is not installable with the CLI, and links to the repository ([#5559](#5559)). ### Bundles * Remove API enum values and types that are still in development from the `databricks-bundles` Python package; these were never accepted by the backend ([#5484](#5484)). * direct: Fix resolving a resource reference that is used more than once within the same field ([#5558](#5558)). * Bundle variable references now accept Unicode letters in path segments (e.g. `${var.变量}`). ([#5532](#5532)) * Ignore remote changes for vector search direct_access_index_spec.schema_json to prevent drift when the backend normalizes the schema ([#5481](#5481)). * Remove hidden, never-functional `--existing-dashboard-id`, `--existing-dashboard-path`, `--existing-alert-id`, and `--existing-genie-space-id` alias flags from `bundle generate`; use the documented `--existing-id` / `--existing-path` flags instead ([#5591](#5591)). * engine/direct: Fix WAL corruption after two consecutive failed deploys ([#5606](#5606)). * engine/direct: Don't open the deployment state WAL when a deploy's plan fails ([#5607](#5607)). * Ignore unity catalog managed schema property defaults to avoid unnecessary drift ([#5195](#5195)). * Add `postgres_roles` and `postgres_databases` resources to create Postgres roles and databases on a Lakebase branch ([#5467](#5467), [#5627](#5627)). * direct: Stop spurious recreate/rename on redeploy when the backend normalizes a resource's name-based ID (e.g. Unity Catalog lowercasing a schema or volume name) ([#5599](#5599)). * Fix the generated pipeline README to suggest `databricks bundle run <pipeline> --refresh <table>` for running a single transformation; the previously documented `--select` flag is not supported by `bundle run` ([#5252](#5252)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Extend bundle variable-reference path parsing from ASCII-only to Unicode letters across Go (
libs/dyn/dynvar), Python (databricks/bundles/core/_transform.py), and bundle JSON Schema (bundle/internal/schema/main.go). Go and Python share behavioral parity vialibs/dyn/dynvar/testdata/reference_vectors.json.Why
DECO-27314: the direct deployment engine could not parse bundle configs that use Unicode letters in
${var...}path segments (e.g.${var.变量}). The regex previously accepted only[a-zA-Z].The shared
reference_vectors.jsonfile was added to automate parity between the Go and Python variable-reference parsers. These implementations are expected to stay in sync, but there were no explicit checks to ensure that before this change. Both sides now run the same vector suite (TestReferenceVectorsin Go,test_variable_reference_vectorsin Python), and the Python test task tracks the vector file as a source dependency.Tests
go test ./libs/dyn/dynvar -run TestReferenceVectors— shared vector file exercises match, reference extraction, pure-reference detection, and path parsing in Gopytest python/databricks_tests/core/test_variable_reference_vectors.py— same vectors run against Python_base_var_defunicode_variable_reference.yml,cjk_numeral_variable_reference.yml,variable_reference_separators.yml,invalid_unicode_variable_reference.yml,nfd_unicode_variable_reference.ymlgo test ./acceptance -run TestAccept/bundle/variables/unicode_reference