direct: Fix resolving a reference used more than once in the same field#5558
Merged
Conversation
A reference like ${resources.pipelines.foo.name} that appears more than
once within the same string field fails to resolve with the direct
engine ("reference not found"), while the terraform engine resolves all
occurrences. Recorded outputs document the current (broken) behavior;
see Badness in test.toml.
Co-authored-by: Isaac
dynvar's References() returns one entry per occurrence, while
StructVar.ResolveRef substitutes every occurrence of a reference in one
call and then drops the entry from Refs. The resolution loop therefore
failed with "reference not found" on the second occurrence of the same
reference within a single field, e.g.:
name: ${resources.pipelines.foo.id} ${resources.pipelines.foo.id}
Deduplicate references per field before resolving. This covers both the
plan-time path (input fields) and the post-deploy path (ids of created
resources), as shown by the duplicate_ref acceptance test which now
passes identically under both engines.
Co-authored-by: Isaac
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Jun 11, 2026
Collaborator
|
Commit: b0c0c2b
24 interesting tests: 15 SKIP, 7 KNOWN, 2 flaky
Top 27 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 1a80611
519 interesting tests: 434 MISS, 44 FAIL, 21 RECOVERED, 11 KNOWN, 4 flaky, 3 PANIC, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-tagging Bot
added a commit
that referenced
this pull request
Jun 17, 2026
## Release v1.4.0 ### CLI * Improved error messages for `ssh connect`: when an SSH connection attempt fails, the client now fetches and prints the server's recent error logs ([#5555](#5555)). * Increase the SSH server startup timeout from 10 to 45 minutes when a GPU accelerator is requested via `databricks ssh connect --accelerator` ([#5569](#5569)). * Fix authentication falling back to the default profile in `.databrickscfg` when a host is already configured via the environment (e.g. `DATABRICKS_HOST` with `DATABRICKS_TOKEN`) ([#5616](#5616)). * ssh: fix opening remote environment in Cursor, which previously hung on default-extension install and never opened the editor ([#5619](#5619)). * Improve the error shown when `databricks labs install` cannot find a project's `labs.yml`: the message now explains that either the requested version does not exist or the project is not installable with the CLI, and links to the repository ([#5559](#5559)). ### Bundles * Remove API enum values and types that are still in development from the `databricks-bundles` Python package; these were never accepted by the backend ([#5484](#5484)). * direct: Fix resolving a resource reference that is used more than once within the same field ([#5558](#5558)). * Bundle variable references now accept Unicode letters in path segments (e.g. `${var.变量}`). ([#5532](#5532)) * Ignore remote changes for vector search direct_access_index_spec.schema_json to prevent drift when the backend normalizes the schema ([#5481](#5481)). * Remove hidden, never-functional `--existing-dashboard-id`, `--existing-dashboard-path`, `--existing-alert-id`, and `--existing-genie-space-id` alias flags from `bundle generate`; use the documented `--existing-id` / `--existing-path` flags instead ([#5591](#5591)). * engine/direct: Fix WAL corruption after two consecutive failed deploys ([#5606](#5606)). * engine/direct: Don't open the deployment state WAL when a deploy's plan fails ([#5607](#5607)). * Ignore unity catalog managed schema property defaults to avoid unnecessary drift ([#5195](#5195)). * Add `postgres_roles` and `postgres_databases` resources to create Postgres roles and databases on a Lakebase branch ([#5467](#5467), [#5627](#5627)). * direct: Stop spurious recreate/rename on redeploy when the backend normalizes a resource's name-based ID (e.g. Unity Catalog lowercasing a schema or volume name) ([#5599](#5599)). * Fix the generated pipeline README to suggest `databricks bundle run <pipeline> --refresh <table>` for running a single transformation; the previously documented `--select` flag is not supported by `bundle run` ([#5252](#5252)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix the direct engine failing to resolve a
${resources.*}reference that is used more than once within the same field.The first commit adds a repro acceptance test with the broken behavior recorded; the second commit applies the fix (dedupe references per field in
resolveReferences) and updates the test outputs, which are now identical under both engines.Why
Fixes #5557
dynvar'sReferences()returns one entry per occurrence, whileStructVar.ResolveRefsubstitutes every occurrence in one call and then drops the entry fromRefs. The second occurrence of the same reference therefore failed with:The terraform engine resolves the same config fine. Reported by a customer whose alert
query_textreferences the same pipeline id more than once.Tests
New acceptance test
bundle/resource_deps/duplicate_refcovers both resolution paths: input-field references (resolved at plan time) andidreferences (resolved after the target is created). Ran the full./task testsuite locally; the only failure wasTestInprocessMode, which fails identically on a cleanmaincheckout in this environment (local module-proxy issue, unrelated).This pull request and its description were written by Isaac.