acceptance: sort get-index schema_json in vector search schema_normalization test#5631
Merged
Merged
Conversation
…ization test The test compares the raw get-index schema_json against a golden with sorted keys. The local test server sorts keys (Go encoding/json) but the cloud backend does not guarantee column order, so the golden was stale and the test failed on cloud. Sorting the keys in the script keeps the comparison stable regardless of backend ordering and is byte-identical to the existing golden. Co-authored-by: Isaac
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
Integration test reportCommit: 34f6390
24 interesting tests: 15 SKIP, 7 KNOWN, 2 flaky
Top 26 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Jun 17, 2026
Collaborator
Integration test reportCommit: 52a43ab
608 interesting tests: 547 MISS, 45 FAIL, 8 KNOWN, 4 PANIC, 2 SKIP, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test compares the raw get-index schema_json against a golden with sorted keys. The local test server sorts keys (Go encoding/json) but the cloud backend does not guarantee column order (even though it did return it sorted previously when added in #5481), so the golden was stale and the test failed on cloud. Sorting the keys in the script keeps the comparison stable regardless of backend ordering and is byte-identical to the existing golden.
Co-authored-by: Isaac