Replacing pytest-cov by coverage - #218
Conversation
|
|
||
| [tool:pytest] | ||
| addopts = --cov-report= --cov=httpcore --cov=tests -rxXs | ||
| addopts = -rxXs |
There was a problem hiding this comment.
I'd love for us to be using long form flags here at some point. I mean, what the heck does this do?
(Tho, that's nothing to do with this pull request, just makes me notice it more is all.)
There was a problem hiding this comment.
Let's make the flags wide (wait a second please)
There was a problem hiding this comment.
afaik you cant make reporting flags wide,
-r chars show extra test summary info as specified by chars: (f)ailed, (E)rror, (s)kipped, (x)failed, (X)passed, (p)assed, (P)assed with output, (a)ll except passed (p/P), or (A)ll. (w)arnings are enabled by default (see --disable-warnings), 'N' can
be used to reset the list. (default: 'fE').
There was a problem hiding this comment.
Ha :-) There is no long option for -r. The flag combination means:
-r: show extra test summary info as specified by chars: (s)kipped, (x)failed, (X)passed
So yeah, it's a magic
There was a problem hiding this comment.
Well, we oughta treat it separately in any case. Perhaps we don't really want it at all.
Co-authored-by: Tom Christie <tom@tomchristie.com>
lovelydinosaur
left a comment
lovelydinosaur
left a comment
There was a problem hiding this comment.
Yup I'm good with this. Thanks!
Would welcome an equivalent PR in httpx, too.
* Add a link to upstream changelogs * Update optdepends per namcap errors * Drop the hack for pytest-cov, which is no longer used [1] * Don't treat warnings as errors. That is introduced in [2] and causes issues like [3]. [1] encode/httpcore#218 [2] encode/httpcore#442 [3] encode/httpcore#548 git-svn-id: file:///srv/repos/svn-community/svn@1207757 9fca08f4-af9d-4005-b8df-a31f2cc04f65
* Add a link to upstream changelogs * Update optdepends per namcap errors * Drop the hack for pytest-cov, which is no longer used [1] * Don't treat warnings as errors. That is introduced in [2] and causes issues like [3]. [1] encode/httpcore#218 [2] encode/httpcore#442 [3] encode/httpcore#548 git-svn-id: file:///srv/repos/svn-community/svn@1207757 9fca08f4-af9d-4005-b8df-a31f2cc04f65
4 participants
After Kludex/uvicorn#809 it would be great to introduce the same changes in
httpcorePros:
pytest-covmakes work in IDE harder, suppressing breakpoints (link)pytest-covoverwrites somecoverageflags (probably to be compatible with other plugins e.g.pytest-xdist)