Skip to content

configure strict pytest#442

Merged
lovelydinosaur merged 7 commits into
encode:masterfrom
graingert:configure-strict-pytest
Feb 25, 2022
Merged

configure strict pytest#442
lovelydinosaur merged 7 commits into
encode:masterfrom
graingert:configure-strict-pytest

Conversation

@graingert

Copy link
Copy Markdown
Contributor

No description provided.

@graingert

Copy link
Copy Markdown
Contributor Author

a remake of #364

@lovelydinosaur

Copy link
Copy Markdown
Contributor

Thanks @graingert!

@lovelydinosaur

Copy link
Copy Markdown
Contributor

Hrrrmm... I think the warnings that I'm seeing here may be unclosed resources from the httpbin fixture that we're using, rather than actually from httpcore.

(I guess I could be wrong, but I'm seeing the proper socket closes when digging through the codebase.)

@lovelydinosaur

Copy link
Copy Markdown
Contributor

Related - Ideally I'd rather replace our usage of a package based fixture here, with a plain ol' bit of socket code.
Just prefer a more slimline profile, rather than "neat bit of magic that spins up a whole httpbin server". I mean that was great to get going with, but I'd probably rather see a more down-to-basics, "a socket running in another thread that'll always just issue a 200 OK Hello World response".

@stale

stale Bot commented Jan 22, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the wontfix This will not be worked on label Jan 22, 2022
@stale stale Bot removed the wontfix This will not be worked on label Jan 22, 2022
@stale

stale Bot commented Feb 24, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Comment thread setup.cfg Outdated
Comment thread setup.cfg Outdated
Comment thread setup.cfg
Comment thread setup.cfg
Comment thread setup.cfg
Comment on lines +28 to +29
ignore:ssl\.wrap_socket\(\) is deprecated, use SSLContext\.wrap_socket\(\):DeprecationWarning
ignore:ssl\.PROTOCOL_TLS is deprecated:DeprecationWarning

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lovelydinosaur lovelydinosaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on getting this to a resolution. Thanks!

@lovelydinosaur
lovelydinosaur merged commit ebf0684 into encode:master Feb 25, 2022
@graingert
graingert deleted the configure-strict-pytest branch February 25, 2022 12:24
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request May 18, 2022
* Add a link to upstream changelogs
* Update optdepends per namcap errors
* Drop the hack for pytest-cov, which is no longer used [1]
* Don't treat warnings as errors. That is introduced in [2] and causes
  issues like [3].

[1] encode/httpcore#218
[2] encode/httpcore#442
[3] encode/httpcore#548


git-svn-id: file:///srv/repos/svn-community/svn@1207757 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request May 18, 2022
* Add a link to upstream changelogs
* Update optdepends per namcap errors
* Drop the hack for pytest-cov, which is no longer used [1]
* Don't treat warnings as errors. That is introduced in [2] and causes
  issues like [3].

[1] encode/httpcore#218
[2] encode/httpcore#442
[3] encode/httpcore#548

git-svn-id: file:///srv/repos/svn-community/svn@1207757 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants