Skip to content

Align MCP server with the 2026-07-28 specification - #2454

Open
ejsmith wants to merge 7 commits into
feature/exie-assistantfrom
issue/mcp-2026-07-28-conformance
Open

Align MCP server with the 2026-07-28 specification#2454
ejsmith wants to merge 7 commits into
feature/exie-assistantfrom
issue/mcp-2026-07-28-conformance

Conversation

@ejsmith

@ejsmith ejsmith commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • validate the MCP Streamable HTTP Origin header site-wide against the configured public origin
  • tighten Client ID Metadata Document validation and HTTP cache handling
  • align OAuth metadata, challenges, scopes, and authorization responses with the 2026-07-28 MCP specification
  • preserve Exie's structured MCP tool errors and add wire-level coverage
  • update the OpenAPI snapshot and generated Svelte API types

Why

This aligns the MCP and OAuth implementation with the 2026-07-28 specification while preserving down-level protocol support and the MCP server work in #2430.

This PR is intentionally stacked on #2430 and should merge after it.

Impact

Invalid browser origins are rejected with HTTP 403 across the site, while requests without an Origin header and requests from the configured public origin continue normally. OAuth clients receive the required resource scope and issuer metadata. No public API or configuration keys are removed.

Verification

  • Release backend build: 0 warnings, 0 errors
  • Full backend suite: 2,821 passed, 3 skipped, 0 failed
  • OAuth/MCP integration suite: 71 passed
  • CIMD/cache tests: 8 passed
  • MCP metadata tests: 17 passed
  • OpenAPI snapshot tests: 4 passed
  • Svelte npm run check: 0 errors, 0 warnings
  • generated-file formatting and git diff --check: passed

Breaking changes

None.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6be7f66af1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Core/Services/OAuthService.cs Outdated
Comment thread src/Exceptionless.Core/Services/OAuthClientMetadataService.cs Outdated

@niemyjski niemyjski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just missing act assert arrange on tests for consistency.

@niemyjski

Copy link
Copy Markdown
Member

Addressed the remaining review feedback in 6a530e6e3: the newly introduced tests now use explicit Arrange/Act/Assert sections, offline_access remains discoverable for MCP clients, and shared metadata caching honors s-maxage. Post-push build succeeds with 0 warnings/errors; focused metadata tests pass 9/9 and the protected-resource metadata endpoint test passes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6a530e6e30

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Web/Api/Handlers/OAuthHandler.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 839d416bb1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Core/Services/OAuthClientMetadataService.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f4dfa9deac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Web/Mcp/McpOriginValidationMiddleware.cs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc1231e2f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Exceptionless.Web/Mcp/McpOriginValidationMiddleware.cs Outdated
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.Core 75% 67% 10123
Exceptionless.AppHost 38% 41% 147
Exceptionless.Insulation 37% 35% 286
Exceptionless.Web 84% 68% 7891
Summary 78% (24899 / 31941) 67% (11695 / 17487) 18447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants