Fix/csv import export UI - #39
Merged
Merged
Conversation
bronzdoc
approved these changes
May 24, 2021
Contributor
|
@buys-fran update the |
fbuys
force-pushed
the
fix/csv-import-export-ui
branch
2 times, most recently
from
May 24, 2021 15:33
1e0b42c to
5c323a3
Compare
fbuys
commented
May 24, 2021
| mimemagic (~> 0.3.2) | ||
| method_source (1.0.0) | ||
| mimemagic (0.3.5) | ||
| mimemagic (0.3.10) |
Member
Author
|
@bronzdoc could you check a last time please? |
fbuys
force-pushed
the
fix/csv-import-export-ui
branch
from
June 4, 2021 09:50
8c60d72 to
a789a7d
Compare
Member
Author
|
@torresga do you mind doing the QA for this PR? |
Contributor
|
@buys-fran Nope! I will take a look at this on Monday |
Member
|
@torresga I just deployed this to staging: https://staging.points.ombulabs.com @buys-fran It looks a little weird when you are using Safari. Here is a screen recording: points-staging-import-export.mov |
etagwerker
added
Needs Revision
fbuys
force-pushed
the
fix/csv-import-export-ui
branch
from
June 8, 2021 19:29
a789a7d to
8472010
Compare
Member
Author
|
Thanks @etagwerker it looks like Safari/Webkit adds a marker to Detailselements.@torresga , it should be ready for QA now, please 👍 |
Member
Author
|
The additional commits come from: #42 |
Contributor
|
@fbuys hey, could you please fix the git conflict so can do a final QA and then merge it? Thanks! |
This commit will fix: #35 A chevron icon will indicate that a panel will expand downward. Minimal transition will attract attention visually. Also updated the cursor to be a pointer when hovered over the header.
fbuys
force-pushed
the
fix/csv-import-export-ui
branch
from
September 10, 2021 20:35
51581f2 to
c6cb03c
Compare
Member
Author
torresga
approved these changes
Sep 13, 2021
torresga
left a comment
torresga
left a comment
Contributor
There was a problem hiding this comment.
I QAed this - it works/looks as expected to me.
JuanVqz
added a commit
that referenced
this pull request
Jul 21, 2026
* Fix flaky madmin projects index spec The spec asserted the raw project title appears in the rendered page, but the title is HTML-escaped (e.g. an apostrophe becomes '), so it failed intermittently whenever Faker generated a company name with special characters. Compare against the HTML-escaped title instead. * Load routes before suite so Devise mappings resolve on Rails 8.1 Rails 8.1 loads routes lazily. Devise registers its scope mappings while the routes are drawn (devise_for), so before the routes load Devise.mappings is empty and every controller-spec sign_in raises 'Could not find a valid mapping'. Force the routes to load in a before(:suite) hook, which fixes the build-rails-next lane and is harmless on Rails 8.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
_Closes #35 _
Add icon and hover effect to indicate that the CSV import/export header is clickable.
Screen.Recording.2021-05-24.at.16.47.46.mov
Note:
Added to gitignore
Had to update mimemagic before I could bundle install.
The additional commits come from: #42
QA
Test the CSV import/expansion panel.
Is it obviously clickable?
Does it work when you reload the page?
I will abide by the code of conduct.