Skip to content

Feature/project duplicate - #42

Merged
bronzdoc merged 2 commits into
fix/csv-import-export-uifrom
feature/project-duplicate
Jun 1, 2021
Merged

Feature/project duplicate#42
bronzdoc merged 2 commits into
fix/csv-import-export-uifrom
feature/project-duplicate

Conversation

@fbuys

@fbuys fbuys commented May 25, 2021

Copy link
Copy Markdown
Member

Description:

This PR closes: #33

It adds a route and action for duplicating projects.
It adds a button that posts to the duplicate route.

A new Clone Project button was added.
Before:
image

After:
image

image

I will abide by the code of conduct.

@fbuys
fbuys requested a review from a team as a code owner May 25, 2021 17:55
@fbuys
fbuys requested review from bronzdoc and rdormer and removed request for a team May 25, 2021 17:55
@fbuys
fbuys changed the base branch from main to fix/csv-import-export-ui May 25, 2021 17:56
@fbuys

fbuys commented May 27, 2021

Copy link
Copy Markdown
Member Author

@FionaDL do you mind taking a look here and letting me know if there is anything you would like to add?

@FionaDL FionaDL left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buys-fran I think this covers everything that I was hoping for. One small grammar comment. Also, the tests are failing, looks like maybe there is a syntax error in one of the tests.

Comment thread spec/controllers/projects_controller_spec.rb Outdated
@fbuys
fbuys force-pushed the feature/project-duplicate branch from 2b5cd08 to 3791ffd Compare May 28, 2021 11:59
@FionaDL

FionaDL commented Jun 1, 2021

Copy link
Copy Markdown
Member

@buys-fran looks good. @fastruby/black-bunny-brigade I approved this, but maybe someone else wants to look it over as well. It needs to be QA'ed.

@bronzdoc
bronzdoc merged commit 8c60d72 into fix/csv-import-export-ui Jun 1, 2021
@bronzdoc
bronzdoc deleted the feature/project-duplicate branch June 1, 2021 15:02
@fbuys fbuys mentioned this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create the ability to copy a project or stories into another project

3 participants