Skip to content

fix(init): keep select prompts within terminal - #1385

Merged
betegon merged 3 commits into
mainfrom
fix/init-select-terminal-height
Aug 7, 2026
Merged

fix(init): keep select prompts within terminal#1385
betegon merged 3 commits into
mainfrom
fix/init-select-terminal-height

Conversation

@betegon

@betegon betegon commented Aug 7, 2026

Copy link
Copy Markdown
Member

Summary

Keep Ink select and multiselect prompts within the available terminal height by rendering a moving option window. Long labels stay on one row, and position indicators make hidden options discoverable without changing keyboard navigation.

This covers the sentry init team picker and the shared prompt UI used by other long lists.

Closes #1376.

Test plan

  • pnpm exec vitest run test/lib/init/ui/ink-app.snapshot.test.tsx test/lib/init/ui/ink-app.property.test.ts — 26 tests passed
  • pnpm run lint — 972 files checked
  • pnpm run typecheck
  • pnpm run check:fragments — passed with the existing unrelated proguard upload coverage warning
  • Manual TTY smoke test at 24x120 with 26 teams: navigated from (1/26) to (26/26) while the footer remained visible
  • Full unit suite: 9,039 passed and 17 skipped; reproduced the same 8 environment-dependent failures already documented on unchanged main (6 timezone assertions and 2 bash completion shell simulations)

@betegon
betegon marked this pull request as ready for review August 7, 2026 10:21
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Aug 7, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0c3601f. Configure here.

Comment thread packages/cli/src/lib/init/ui/ink-app.tsx Outdated
@betegon
betegon merged commit 6903d26 into main Aug 7, 2026
31 checks passed
@betegon
betegon deleted the fix/init-select-terminal-height branch August 7, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select lists break when taller than terminal

1 participant