Add queries for ide search.#119
Conversation
This enables jump-to-definition and find-references in the VS Code extension, for golang source archives.
|
I can confirm that this works 🎉 |
|
Let's hold off on merging this until the corresponding PR for C++ (github/codeql#3308) has gone in. |
|
@jcreedcmu, should we perhaps also change the suite definition file like for C++? |
Ah, yes, absolutely, my mistake for thinking that https://git.semmle.com/Semmle/code/pull/36810 took care of this already. Ooi, can you explain what the difference is in purpose/use between the files auto-generated by that build target, and these suite files? |
|
Yeah, his is all a little confusing. The auto-generated suites are for ODASA and LGTM, the |
|
Cool, good to know. So do I understand right that, e.g. |
|
I think that's right, yes. |
|
The C++ folks still want to do some more performance testing. In our case, the new queries don't interact with any of the existing queries or libraries and aren't added to any of the existing suites either, so I think this is safe to merge. |
This enables jump-to-definition and find-references in the VS Code
extension, for golang source archives.