Java, Javascript, Csharp: Add jump-to-definition queries#3431
Merged
Conversation
This enables jump-to-definition and find-references in the VS Code extension, for javascript source archives.
This enables jump-to-definition and find-references in the VS Code extension, for Java source archives.
jcreedcmu
force-pushed
the
jcreed/jump-to-def-langs
branch
from
867ba24 to
f55f7ce
Compare
This enables jump-to-definition and find-references in the VS Code extension, for C# source archives.
jcreedcmu
force-pushed
the
jcreed/jump-to-def-langs
branch
from
f55f7ce to
beccdce
Compare
hvitved
previously approved these changes
May 11, 2020
hvitved
left a comment
hvitved
left a comment
Contributor
There was a problem hiding this comment.
C# changes LGTM (I haven't tested it though).
Contributor
|
I guess actually with the move of the code from a |
asgerf
previously approved these changes
May 11, 2020
asgerf
left a comment
asgerf
left a comment
Contributor
There was a problem hiding this comment.
Couldn't figure out how to test it but LGTM
Only expose definition-use relation itself, and getEncodedFile.
jcreedcmu
dismissed stale reviews from asgerf, aschackmull, and hvitved
via
66da91f
aschackmull
previously approved these changes
May 12, 2020
hvitved
requested changes
May 12, 2020
| import csharp | ||
|
|
||
| /** An element with an associated definition. */ | ||
| abstract private class Use extends @type_mention_parent { |
hvitved
approved these changes
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #3308 for these languages. Python was already done by #3405. Go was already done by github/codeql-go#119.