Skip to content

csharp: URI should be Uri in Owin.qll library.#11576

Merged
hvitved merged 4 commits into
github:mainfrom
ethanwilloner:main
Dec 7, 2022
Merged

csharp: URI should be Uri in Owin.qll library.#11576
hvitved merged 4 commits into
github:mainfrom
ethanwilloner:main

Conversation

@ethanwilloner

Copy link
Copy Markdown
Contributor

As per the API documentation, OwinRequest Uri property should not be in all caps.
https://learn.microsoft.com/en-us/previous-versions/aspnet/mt152058(v=vs.113)

@github-actions github-actions Bot added the C# label Dec 6, 2022
@ethanwilloner ethanwilloner changed the title Main Bug fix: URI should be Uri in Owin.qll library. Dec 6, 2022
@ethanwilloner ethanwilloner marked this pull request as ready for review December 6, 2022 00:13
@ethanwilloner ethanwilloner requested a review from a team as a code owner December 6, 2022 00:13
@ethanwilloner ethanwilloner changed the title Bug fix: URI should be Uri in Owin.qll library. csharp: URI should be Uri in Owin.qll library. Dec 6, 2022

@hvitved hvitved left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Comment thread csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll Outdated
@hvitved hvitved merged commit 51f11f1 into github:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants