Skip to content

csharp: URI should be Uri in Owin.qll library. #11576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 4 commits into from
Dec 7, 2022
Merged

csharp: URI should be Uri in Owin.qll library. #11576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82c0449
Fix bug: In OwinRequest URI should be Uri.
ethanwilloner Dec 6, 2022
b886157
Add change note.
ethanwilloner Dec 6, 2022
574d6d6
Fix comment.
ethanwilloner Dec 6, 2022
64f5806
Rename 2022-12-05-owin-uri-fix.md. to 2022-12-05-owin-uri-fix.md
ethanwilloner Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/Owin.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ class MicrosoftOwinIOwinRequestClass extends Class {
result.hasName("Scheme")
}

/** Gets the `URI` property. */
/** Gets the `Uri` property. */
Property getUriProperty() {
result = this.getAProperty() and
result.hasName("URI")
result.hasName("Uri")
}

/** DEPRECATED: Alias for getUriProperty */
Expand Down
4 changes: 4 additions & 0 deletions csharp/ql/src/change-notes/2022-12-05-owin-uri-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: fix
---
* Fixes a bug where the Owin.qll framework library will look for "URI" instead of "Uri" in the OwinRequest class.