Skip to content

Swift: route compiler diagnostics through our log#12760

Merged
redsun82 merged 1 commit into
mainfrom
redsun82/swift-logging-compiler
Apr 18, 2023
Merged

Swift: route compiler diagnostics through our log#12760
redsun82 merged 1 commit into
mainfrom
redsun82/swift-logging-compiler

Conversation

@redsun82

@redsun82 redsun82 commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@redsun82 redsun82 requested a review from sashabu April 4, 2023 15:23
@github-actions github-actions Bot added the Swift label Apr 4, 2023
Comment thread swift/extractor/invocation/SwiftDiagnosticsConsumer.cpp

@sashabu sashabu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please hold off on merging until the base PR is merged (or at least ready to merge).

Base automatically changed from redsun82/swift-logging to main April 17, 2023 13:23
@redsun82 redsun82 force-pushed the redsun82/swift-logging-compiler branch from 70552fc to b8c5561 Compare April 18, 2023 06:46
@redsun82 redsun82 marked this pull request as ready for review April 18, 2023 06:46
@redsun82 redsun82 requested a review from a team as a code owner April 18, 2023 06:46
Comment thread swift/extractor/main.cpp
@redsun82 redsun82 merged commit d777fd9 into main Apr 18, 2023
@redsun82 redsun82 deleted the redsun82/swift-logging-compiler branch April 18, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants