Skip to content

Swift: Route compiler diagnostics through our log.#13869

Merged
sashabu merged 1 commit into
mainfrom
sashabu/swift-logging-compiler
Aug 4, 2023
Merged

Swift: Route compiler diagnostics through our log.#13869
sashabu merged 1 commit into
mainfrom
sashabu/swift-logging-compiler

Conversation

@sashabu

@sashabu sashabu commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Based on #12760 (which was reverted in #12908).

@github-actions github-actions Bot added the Swift label Aug 2, 2023
@sashabu sashabu marked this pull request as ready for review August 3, 2023 12:14
@sashabu sashabu requested a review from a team as a code owner August 3, 2023 12:14
@sashabu sashabu requested a review from redsun82 August 3, 2023 12:15

@redsun82 redsun82 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see the previous problem any more in the DCA run, so probably something from 5.8 to 5.8.1 solved it.

The trap size wobble is indeed weird, but I can't think of any reason how it could be related to this change, considering the successfully extracted files are the same.

@sashabu sashabu merged commit 97c6888 into main Aug 4, 2023
@sashabu sashabu deleted the sashabu/swift-logging-compiler branch August 4, 2023 15:13
@sashabu sashabu restored the sashabu/swift-logging-compiler branch August 8, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants