JavaScript: Make Script and CodeInAttribute concrete.#1393
Merged
Conversation
ghost
approved these changes
Jun 4, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
LGTM. Do we want to undo the change that motivated this PR?
Author
|
Could do, but I think it's also fine to leave that change in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These classes were never intended to be customizable and aren't documented as such, so even though this is technically a breaking change I don't think it needs a change note.
A full evaluation shows a slight performance win (internal link).