Skip to content

JavaScript: Make Script and CodeInAttribute concrete. #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
semmle-qlci merged 1 commit into from
Jun 4, 2019
Merged

JavaScript: Make Script and CodeInAttribute concrete. #1393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions javascript/ql/src/semmle/javascript/AST.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,9 @@ class TopLevel extends @toplevel, StmtContainer {
/**
* A stand-alone file or script originating from an HTML `<script>` element.
*/
abstract class Script extends TopLevel { }
class Script extends TopLevel {
Script() { this instanceof @script or this instanceof @inline_script }
}

/**
* A stand-alone file or an external script originating from an HTML `<script>` element.
Expand All @@ -197,7 +199,9 @@ class InlineScript extends @inline_script, Script { }
/**
* A code snippet originating from an HTML attribute value.
*/
abstract class CodeInAttribute extends TopLevel { }
class CodeInAttribute extends TopLevel {
CodeInAttribute() { this instanceof @event_handler or this instanceof @javascript_url }
}

/**
* A code snippet originating from an event handler attribute.
Expand Down